Re-enable Continuous Queries #2200
Conversation
| log.Println("broker cq: no topics currently available.") | ||
| return // don't have any topics to get data urls from, give it up | ||
| } | ||
| dataURLs := topic.DataURLs() |
There was a problem hiding this comment.
This is a strange way to get the URLs. :-) I know why a topic knows about the URLs, but is there no other way?
There was a problem hiding this comment.
We should probably add a convenience method to the broker which is something like:
func (b *Broker) DataURLs() ([]url.URL, bool)And then we can hide some of this searching around.
There is no other way that a broker will know about data urls right now.
|
I'm not sure, but is the broker-only code only supposed run on the leader broker? |
|
@otoolep Only the leader broker should kick off CQ's, as we only want one person "directing traffic" with cq's. I don't think we have another way to schedule a unique job right now. Was that what you were asking? |
|
Yes, I want to make sure that we're still only kicking off the CQ from the leader. I don't think we did anything to affect that, but wanted to be sure. |
|
@otoolep correct, here are the lines that make sure that happens: https://github.com/influxdb/influxdb/blob/renenable-cq/broker.go#L68-L70 |
|
👍 |
…skipable Make client generation optional via ENV variable
This was previously removed due to the stateless broker refactoring. Now that brokers know about data nodes again, this was added back in.
Fixes #1666